Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::error with core::error #2118

Open
StackOverflowExcept1on opened this issue Jun 23, 2024 · 3 comments
Open

Replace std::error with core::error #2118

StackOverflowExcept1on opened this issue Jun 23, 2024 · 3 comments

Comments

@StackOverflowExcept1on
Copy link

StackOverflowExcept1on commented Jun 23, 2024

ring/src/error.rs

Lines 86 to 87 in 525047a

#[cfg(feature = "std")]
impl std::error::Error for Unspecified {}

rust-lang/rust#125951

@briansmith
Copy link
Owner

We can add a core-error feature flag to ring that will do this, I suppose. Not sure what the use case is.

@StackOverflowExcept1on
Copy link
Author

Well, maybe use case is to not depend on std and be able to use crates like thiserror

@briansmith
Copy link
Owner

This idea seems fine with me, but it'd need to be behind a feature flag because we aren't raising the MSRV yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants