From ea0af299a36d4978403cfd0baca6310bb8034e93 Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Fri, 16 Nov 2018 15:46:27 +0800 Subject: [PATCH 1/6] Update README.md https://github.com/brianfrankcooper/YCSB/issues/1212 The YCSB readme is as the following, which is a little misleading.Because we can't use '-p durability=false' to disable durability. Instead it worked when I used '-p durability=SKIP_WAL'. The readme should be written more clearly. durability: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. --- hbase12/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase12/README.md b/hbase12/README.md index ea658e7c05..0ef6034d36 100644 --- a/hbase12/README.md +++ b/hbase12/README.md @@ -23,5 +23,5 @@ See `hbase098/README.md` for a quickstart to setup HBase for load testing and co ## Configuration Options In addition to those options available for the `hbase098` binding, the following options are available for the `hbase12` binding: -* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. +* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. We can set it to flase by option '-p durability=SKIP_WAL'. From 176b3b7e412be596d6b85a0095f8b5f760caea5b Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Fri, 12 Jul 2019 20:02:11 +0800 Subject: [PATCH 2/6] Update Client.java --- core/src/main/java/com/yahoo/ycsb/Client.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/com/yahoo/ycsb/Client.java b/core/src/main/java/com/yahoo/ycsb/Client.java index 4fc427b07e..d745e87bf0 100644 --- a/core/src/main/java/com/yahoo/ycsb/Client.java +++ b/core/src/main/java/com/yahoo/ycsb/Client.java @@ -857,7 +857,10 @@ private static List initDb(String dbname, Properties props, int th opcount = Integer.parseInt(props.getProperty(RECORD_COUNT_PROPERTY, DEFAULT_RECORD_COUNT)); } } - + if (threadcount > opcount){ + threadcount = opcount; + System.println("Warning: the threadcount is bigger than recordcount, the threadcount will be recordcount!"); + } for (int threadid = 0; threadid < threadcount; threadid++) { DB db; try { From b079b04ace39273f3eab6bbf4ed78e092aa250eb Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Fri, 12 Jul 2019 20:23:08 +0800 Subject: [PATCH 3/6] Update Client.java --- core/src/main/java/com/yahoo/ycsb/Client.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/com/yahoo/ycsb/Client.java b/core/src/main/java/com/yahoo/ycsb/Client.java index d745e87bf0..59f368fd16 100644 --- a/core/src/main/java/com/yahoo/ycsb/Client.java +++ b/core/src/main/java/com/yahoo/ycsb/Client.java @@ -859,7 +859,7 @@ private static List initDb(String dbname, Properties props, int th } if (threadcount > opcount){ threadcount = opcount; - System.println("Warning: the threadcount is bigger than recordcount, the threadcount will be recordcount!"); + System.out.println("Warning: the threadcount is bigger than recordcount, the threadcount will be recordcount!"); } for (int threadid = 0; threadid < threadcount; threadid++) { DB db; From da82042918285e351ee3a57f68034d3b96eb17cf Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Sat, 13 Jul 2019 19:08:57 +0800 Subject: [PATCH 4/6] update core.client.java It's related to issue https://github.com/brianfrankcooper/YCSB/issues/1176 --- hbase12/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase12/README.md b/hbase12/README.md index 0ef6034d36..182828d822 100644 --- a/hbase12/README.md +++ b/hbase12/README.md @@ -23,5 +23,5 @@ See `hbase098/README.md` for a quickstart to setup HBase for load testing and co ## Configuration Options In addition to those options available for the `hbase098` binding, the following options are available for the `hbase12` binding: -* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. We can set it to flase by option '-p durability=SKIP_WAL'. +* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. From 4cef559b9f1d5eb6bce134f9b97d933e8ae0445d Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Sat, 13 Jul 2019 19:19:52 +0800 Subject: [PATCH 5/6] Update README.md --- hbase12/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase12/README.md b/hbase12/README.md index 182828d822..74bee71ff1 100644 --- a/hbase12/README.md +++ b/hbase12/README.md @@ -23,5 +23,5 @@ See `hbase098/README.md` for a quickstart to setup HBase for load testing and co ## Configuration Options In addition to those options available for the `hbase098` binding, the following options are available for the `hbase12` binding: -* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. +* `durability`: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true. We can set it to flase by option '-p durability=SKIP_WAL'. From b4588c6ee71e482c25d5c3db9553984d496154dd Mon Sep 17 00:00:00 2001 From: adally <907666634@qq.com> Date: Sat, 13 Jul 2019 19:43:06 +0800 Subject: [PATCH 6/6] Update Client.java --- core/src/main/java/com/yahoo/ycsb/Client.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/core/src/main/java/com/yahoo/ycsb/Client.java b/core/src/main/java/com/yahoo/ycsb/Client.java index 59f368fd16..4fc427b07e 100644 --- a/core/src/main/java/com/yahoo/ycsb/Client.java +++ b/core/src/main/java/com/yahoo/ycsb/Client.java @@ -857,10 +857,7 @@ private static List initDb(String dbname, Properties props, int th opcount = Integer.parseInt(props.getProperty(RECORD_COUNT_PROPERTY, DEFAULT_RECORD_COUNT)); } } - if (threadcount > opcount){ - threadcount = opcount; - System.out.println("Warning: the threadcount is bigger than recordcount, the threadcount will be recordcount!"); - } + for (int threadid = 0; threadid < threadcount; threadid++) { DB db; try {