Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'mongodb' client is not honoring the maxPoolSize=XX for the number of client connections. #317

Open
allanbank opened this issue Jun 22, 2015 · 3 comments

Comments

@allanbank
Copy link
Collaborator

'mongodb' client is not honoring the maxPoolSize=XX for the number of client connections. Instead it is opening a connection per YCSB client thread.

@manolama
Copy link
Collaborator

@allanbank Is this still an issue or does the client initialize once per YCSB run properly? Thanks.

@allanbank
Copy link
Collaborator Author

I will try and check this weekend.

@vlsi
Copy link

vlsi commented Feb 3, 2018

@manolama , the issue is current implementation of MongoDB adapter is it is using 100 connections by default. Even though "100 connections is enough", it bites when one tries to benchmark with lots of clients (e.g. 500 or 1000) on a multicore machine (e.g. 70 cores).

On contrary, JdbcDBClient uses connection-per-client approach. The implementation difference makes benchmark result comparison obscure.

What do you think of creating a common property db.pool.size that would designate the number of connections in a connection pool?

Certain implementations (e.g. Mongo) would just leverage existing implementation (e.g. maxPoolSize url property for Mongo). The others might need a connection pooler (e.g. HikariCP for JDBC).

Having a common property would enable comparison in a controlled environments and it would simplify results comparison.

PS. I think it makes sense to use db.pool.size equal to the number of YCSB threads by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants