JDBC Binding does not support multiple host for failover

[seybi87]

Hi guys,
I was trying to benchmark CockroachDB (using the JDBC binding and the PostgreSQL JDBC connector) with respect to node failures and I came across the following issue:

JDBC support multiple host in the connection String to enable failover, e.g.:
jdbc:postgresql://host1:port1,host2:port2/database

Yet, the current JDBC-binding epects multiple hosts only in the following form:
jdbc:postgresql://host1:port1/database,jdbc:postgresql://host2:port2/database

And as the provided connection String is split by "," to create multiple connections (check the respsective line 198 JDBC-Binding ) this will result in an error for the failover connection String with multiple hosts.

Hence, the splitting identifier at line 198 should be changed to sth. which not conflicts with JDBC connection string chars.

I did a simple test by replacing "," with ";" and it worked without a problem for a failover connection String.

Would be great if you can apply this fix for upcoming releases

Cheers,
Daniel

[busbey]

Hi Daniel! do you have the time to put together a PR?

[seybi87]

Yes, I will try to do it within the next days.

[busbey]

Any progress?

[seybi87]

Sorry for coming back to this quite late.

Just submitted a pull request to fix this issue

[busbey]

#1233 has been merged.