Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook #88

Open
pattruong opened this issue Dec 23, 2020 · 1 comment
Open

Storybook #88

pattruong opened this issue Dec 23, 2020 · 1 comment
Labels
backlog Need more investigation. Possibly low priority design Broad tag for UI/UX topics dx Developer Experience: improves our ability to work or collaborate testing tests

Comments

@pattruong
Copy link
Member

pattruong commented Dec 23, 2020 •
edited
Loading

Overview

  • consider adding storybook - tutorial w/ tailwind
  • would be helpful for auditing components and overall design
  • especially helpful for viewing dark mode changes
  • integration for group reviewing - chromatic & publish doc
    • I think this is super cool because it could be a very good alternative to writing unit tests for component/visual tests (I don't like to rely on tests for things that are inherently impure functions)
    • I think the allowance for having us/stakeholders all review a UI for quality leads to better code, UI, and understanding of our brand design

Required work

  • will require adding components one at a time. Process will involve extracting any coupled state/queries from component
@pattruong pattruong added design Broad tag for UI/UX topics ui labels Dec 23, 2020
@pattruong pattruong added this to the alpha v0.2 milestone Dec 23, 2020
@pattruong pattruong added dx Developer Experience: improves our ability to work or collaborate testing tests and removed ui labels Feb 18, 2021
@pattruong pattruong assigned pattruong and jaamz and unassigned pattruong Feb 18, 2021
@pattruong pattruong assigned pattruong and unassigned jaamz Mar 8, 2021
@pattruong pattruong removed this from the alpha v0.2 milestone Mar 8, 2021
@pattruong pattruong added the backlog Need more investigation. Possibly low priority label Mar 8, 2021
@pattruong
Copy link
Member Author

⚠️ Adding to backlog due to no official support for craco which is required due to postcss 8 being incompatible with CRA (we care about this because of TailwindCSS). Tried it and failed on build due to Webpack config issues, I don't think it's worth the time to setup at the moment

@pattruong pattruong removed their assignment Mar 12, 2021
@pattruong pattruong mentioned this issue Mar 15, 2021
Merged
@pattruong pattruong added this to the alpha v0.3 milestone Apr 15, 2021
@pattruong pattruong removed this from the Stability 2021 Q2 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Need more investigation. Possibly low priority design Broad tag for UI/UX topics dx Developer Experience: improves our ability to work or collaborate testing tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pattruong @jaamz