Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal outdated check before release #660

Closed
endgame opened this issue Oct 1, 2021 · 3 comments · Fixed by #678
Closed

cabal outdated check before release #660

endgame opened this issue Oct 1, 2021 · 3 comments · Fixed by #678
Milestone

Comments

@endgame
Copy link
Collaborator

endgame commented Oct 1, 2021

No description provided.

@endgame endgame added this to the 2.0 RC 1 milestone Oct 1, 2021
@endgame
Copy link
Collaborator Author

endgame commented Oct 10, 2021

In particular, make sure we support aeson-2.0.0.0

@brendanhay
Copy link
Owner

From aeson-2.0.1.0 onward, ordered Map is the default so we should consider having the generator emit Map fields instead of HashMap - if for no other reason than to minimise Map -> HashMap conversions, but it also just seems like a more sensible default given potentially untrusted inputs / hash flooding.

See: haskell/aeson#864

@endgame
Copy link
Collaborator Author

endgame commented Oct 11, 2021

I wonder if we should aim for aeson < 1.6 for amazonka-2.0 and then aeson >= 2.0 && < 2.1 for amazonka-2.1? We'll be asking a lot of our downstream users for the 2.0 release, as there's all the other breaking changes from the existing improvements on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants