Expose the Lambda context in LAMBDA_INVOCATION_CONTEXT in all runtimes
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private function setEnv(string $name, string $value): void | ||
| { | ||
| $_SERVER[$name] = $_ENV[$name] = $value; | ||
| if (! putenv("$name=$value")) { |
There was a problem hiding this comment.
Do we have to use putenv?
There was a problem hiding this comment.
That's in case a user is using getenv.
Do you see any issue? It's not like we're doing multithreading.
There was a problem hiding this comment.
Yeh, I still don't like it. Why do people even use getenv? I assume it's just because PHP named things in a way that's super confusing, and people reach for it as "the way to read env variables", even though $_SERVER is actually the closest approximation to "the list of env variables".
There was a problem hiding this comment.
If the argument is "I don't like it" that's not enough for me :p 😈
I agree this isn't the best, but might as well support it if anyone uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1685 that reverted #1668. This is a different implementation.