Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LUD-02 - Your wallet doesn't follow the standard - can't open channels #1305

Open
LNBIG-COM opened this issue Aug 7, 2024 · 0 comments

Comments

@LNBIG-COM
Copy link

LNBIG-COM commented Aug 7, 2024

General Description

Because your wallet does not follow the standard - it is not possible to open inbound channels via the LNURL mechanism. I checked - the problem is on your side.

How To Reproduce?

  1. Go to lnbig.com
  2. Make prepayment
  3. To try scan a QR-Code of LNURL
  4. You will see a message from lnbig.com site that your browser is offline. It's an indirect error. It's actually a different error.

In fact, the problem is simple and your wallet is violating the standard, viz:

The standard LUD-02 defines the discovery procedure:

Wallet to service interaction flow:
...
4. LN WALLET opens a connection to the target node using uri field.
5. LN WALLET issues a GET request to LN SERVICE using <?/&>k1=&remoteid=&private=<1/0> if user decides to proceed or <?/&>k1=&remoteid=&cancel=1 if user decides to cancel a channel midway.

Your wallet for some reason does not make the connection to the node it received in JSON (point 3 in the LUD-02 standard - uri field), instead it immediately calls the callback URL, and for some reason several times (probably because the first time it receives an error from LNBIG, as there is no connection from Breez to the LNBIG node specified to it).

In general, if Breez were following the standard, it should establish a connection to the LNBIG peer it received when making a valid request to the LNURL-encoded URL, and ONLY AFTER THAT callback should be called (ONE TIME!).

Instead it acts incorrectly and calls callback several times before establishing a connection, which of course can be considered by any LSP provider as a DOS attack. Which is what is done on the LNBIG site.

It's a very old bug. I observed it a few years ago, but I never had the time to write to you about it. It hasn't been fixed in many years :(

Breez Version

Android version 0.17.6-beta

@LNBIG-COM LNBIG-COM changed the title LUD-02 - Your wallet doesn't follow the standard - can't open channels [BUG] LUD-02 - Your wallet doesn't follow the standard - can't open channels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant