Skip to content

Latest commit

 

History

History
25 lines (23 loc) · 1.54 KB

CONTRIBUTING.md

File metadata and controls

25 lines (23 loc) · 1.54 KB
Raw

Contribution acceptance criteria

  1. The change is as small as possible. It fixes one specific issue or implements one specific feature. Do not combine things, send separate pull requests if needed.
  2. Include proper tests and make all tests pass (unless it contains a test exposing a bug in existing code). Every new class should have corresponding unit tests, even if the class is exercised at a higher level, such as a feature test.
  3. Every bug-fix has a regression test.
  4. If you suspect a failing CI build is unrelated to your contribution, you may try and restart the failing CI job or ask a developer to fix the aforementioned failing test.
  5. Code conforms to this style guide.
  6. When writing tests, please follow these guidelines.
  7. Changes do not adversely degrade performance.
  8. Your PR contains a single commit (please use git rebase -i to squash commits)
  9. When writing commit messages, please follow these guidelines.
  10. Your changes can merge without problems (if not please rebase if you're the only one working on your feature branch, otherwise, merge master).
  11. If the pull request adds any new libraries, they should be in line with our license.
  12. Use GoodData.logger for logging instead of puts.

Based on GitLab's contribution guide.