Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Chat]: Clean up the SiteInfo struct #43293

Open
fallaciousreasoning opened this issue Jan 15, 2025 · 0 comments · May be fixed by brave/brave-core#27243
Open

[AI Chat]: Clean up the SiteInfo struct #43293

fallaciousreasoning opened this issue Jan 15, 2025 · 0 comments · May be fixed by brave/brave-core#27243
Assignees

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Jan 15, 2025

  1. SiteInfo should be renamed to AssociatedContent
  2. The is_content_association_possible field should be removed - the presence/absence of AssociatedContent should imply whether its possible.
  3. The optional fields on AssociatedContent should be made non-optional. They were originally set to optional as the struct was always present. Now it will only be present when there is AssociatedContent.
  4. Remove the hostname field - its inferrable from the url field and adds nothing

This cleanup will make adding support for associating multiple bits of content far easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant