Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP initial render is slowed down due to large bundle size #9913

Closed
petemill opened this issue May 22, 2020 · 0 comments · Fixed by brave/brave-core#5634
Closed

NTP initial render is slowed down due to large bundle size #9913

petemill opened this issue May 22, 2020 · 0 comments · Fixed by brave/brave-core#5634

Comments

@petemill
Copy link
Member

Description

New Tab Page's JS bundle is a single 1.34mb file. This takes time to parse before the initial render happens.
Seems like most of it is taken up by css and fonts which is not necessary for the initial JS to run.

Steps to Reproduce

From src/brave, run:

DEPFILE_PATH=$TMPDIR/brave-temp-depfile-webpack DEPFILE_SOURCE_NAME=wtf npm run web-ui -- --mode=production brave_new_tab_ui=$PWD/components/brave_new_tab_ui/brave_new_tab.tsx --progress

Actual result:

1340mb

Expected result:

<500k

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants