Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards & Binance widget menus go off screen on certain window widths #9390

Closed
LaurenWags opened this issue Apr 22, 2020 · 2 comments · Fixed by brave/brave-core#5319
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Apr 22, 2020

Description

Similar to #9389

On certain window widths, the widget menu for Rewards and Binance widgets goes off screen. Seems to happen on approximately 950-1140px window width as #9389 does.

Steps to Reproduce

  1. Set window width to somewhere within approx 950-1140px width
  2. Open Rewards or Binance widget menu

Actual result:

Off screen:
Screen Shot 2020-04-22 at 11 29 18 AM

Expected result:

widget menu should not be off screen, this is how it behaves on other window widths:
Screen Shot 2020-04-22 at 11 37 28 AM

Screen Shot 2020-04-22 at 11 38 00 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, not on 1.7.x
  • Can you reproduce this issue with the beta channel? yes (1.8.x)
  • Can you reproduce this issue with the dev channel? yes (1.9.x)
  • Can you reproduce this issue with the nightly channel? yes (1.10.x)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/legacy_qa @bsclifton

@LaurenWags
Copy link
Member Author

Possibly related to #8883

@btlechowski
Copy link

btlechowski commented May 28, 2020

Verification passed on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Reproduced the issue on 1.9.x
image

Verified test plan from brave/brave-core#5319 and the description
image
image

Also verified other resolutions for regressions.

Verification passed on


Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Reproduced on 1.9.x
image

Verified test plan from brave/brave-core#5319 and the description
image


Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

window.innerWidth < 950
Screen Shot 2020-06-01 at 10 09 06 AM

window.innerWidth = 950
Screen Shot 2020-06-01 at 10 07 20 AM

940 < window.innerWidth < 1140
Screen Shot 2020-06-01 at 10 09 51 AM

window.innerWidth = 1140
Screen Shot 2020-06-01 at 10 08 40 AM

window.innerWidth > 1140
Screen Shot 2020-06-01 at 10 09 24 AM

@rebron rebron changed the title rewards & binance widget menus go off screen on certain window widths Rewards & binance widget menus go off screen on certain window widths Jun 1, 2020
@rebron rebron changed the title Rewards & binance widget menus go off screen on certain window widths Rewards & Binance widget menus go off screen on certain window widths Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment