-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Do not show 0.0 BAT for monthly ad earnings in the Monthly Contribution Statements for verified wallets #9211
Comments
cc @mandar-brave @jenn-rhim also |
Query parameters possible for pagination: e.g., |
Confirmation by Uphold.
Stick with simple solution for now. Do not download and parse .csv: |
The earning should be indicated here regardless of where the tokens are stored/managed, just as the total balance. This seems to have gotten off the rail somewhere. |
@jenn-rhim Unfortunately, the issue (I was told by Nejc back in the day, and I think is probably still true) is that because they're direct deposits to Uphold, we don't have easy access to the accounting, so we can't fetch this information easily :(. I think this would just be a temporary solution until we fix these issues from the bottom up (for instance, with pure virtual wallets). |
This will be resolved properly (not with a stopgap solution) once this is implemented: #15320 Edit see below. |
I think we should just go with the stopgap solution for now as initially proposed (link out to the custodians' transaction page). It's an easier win and will end confusion in the immediate term. Waiting for #15320 may take too long, and #15320 might become obsolete anyway if/when we move away from direct deposits. |
Going with |
Related: #18159 |
Verified passed with
Verified test plan from brave/brave-core#10152 (comment) Anon walletConfirmed that there is not a Uphold walletConfirmed that there is a
|
If the Brave Rewards wallet is verified, then earnings for each month where the wallet is verified will display 0.0 BAT (since ads earnings are sent directly to the user's Uphold account, rather than being accounted for within the browser). Instead of displaying 0.0 BAT, the interface should display an informative message about this case or, e.g., link to the user's Uphold transactions page.
Displaying 0.0 BAT for "Earnings from Ads" may be confusing to users. For example, in the above screenshot, the user did have ad earnings for that month, but the statement still displays 0.0 BAT.
Possible Solution:
Make some conditional logic such that if the wallet is verified for some month, then replace "0.0 BAT" with a link to the user's Uphold account, or some other message.
Update: Hyperlink text == "View deposit history"
Add correct accounting in the verified case.Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit) MacOS
The text was updated successfully, but these errors were encountered: