Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] [Security] Add setting in brave://settings/appearance to display full URL in address bar #7449

Closed
Brave-Matt opened this issue Dec 18, 2019 · 19 comments · Fixed by brave/brave-core#6116

Comments

@Brave-Matt
Copy link

Description

#omnibox-ui-hide-steady-state-url-trivial-subdomains
#omnibox-ui-hide-steady-state-url-scheme

The above flags, which controlled whether or not the entire URL was displayed in the address bar, have been removed from the Chromium code. Many users have requested these options be returned to the browser. Further, it's also something users would frequently ask how to do even before the flags were removed. I believe there are enough users interested in having this option available to warrant consideration for bringing it back.
image

Miscellaneous Information:

User reports:

@rebron
Copy link
Collaborator

rebron commented Dec 18, 2019

cc: @tomlowenthal @petemill for thoughts

@Madis0
Copy link

Madis0 commented Jan 1, 2020

This option should mainly toggle the old elisions in Chromium (protocol hiding, trailing slash, username-password, possibly punycode display).
The subdomain "www" should always be displayed as the contents can and do differ in several sites, including sites that just don't work without www. See also web developers' arguments: https://bugs.chromium.org/p/chromium/issues/detail?id=883038

@Renerick
Copy link

Temporary workaround for this issue is in the discussion as well: https://bugs.chromium.org/p/chromium/issues/detail?id=883038#c203 (download the file, put it in some directory and install as unpacked extension)

Nevertheless, this behavior is still a problem for many users and I think it should be addressed ASAP

@bsclifton
Copy link
Member

bsclifton commented Jan 13, 2020

cc: @diracdeltas

We did close a past issue (#6689) as wontfix, but we could consider wrapping a flag around the work-around that @Renerick provided (maybe even putting into Brave extension)

@Brave-Matt
Copy link
Author

Some more users here requesting this feature:
https://community.brave.com/t/display-full-url/89775/30

@Madis0
Copy link

Madis0 commented Apr 16, 2020

The option is now upstream (canary), behind a flag. https://bugs.chromium.org/p/chromium/issues/detail?id=1061576

@Sa-Ja-Di
Copy link

@Brave-Matt How about following user interests and user suggestions? People want customization, features and choice and not simplicity - old Brave with it's custom UI offered that, Brave now offers almost nothing.

When do you guys bring back finally some features and customization? Where is your support for power and advanced users?

@rebron rebron added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Apr 17, 2020
@Brave-Matt
Copy link
Author

@rebron
Copy link
Collaborator

rebron commented May 11, 2020

brave://flags/#omnibox-context-menu-show-full-urls This flag when enabled, starting in Chromium 83 should show an option via context menu to display the full address bar.

@stefankeys
Copy link

Vivaldi and Opera seem to have implemented this feature.

@EricReuss
Copy link

I've been looking for this feature not for security reasons but for UX ones - when I go to edit a portion of a URL, it's really frustrating to have the text shift out from under the mouse cursor as I double-click.

I'm glad it's coming down the pipe, though I have to say that "set a special flag to enable a context menu item to provide the desired functionality" sounds like a pain... especially if it only sets it for one window (I can't tell from the comment).

@Madis0
Copy link

Madis0 commented May 21, 2020

@EricReuss

I'm glad it's coming down the pipe, though I have to say that "set a special flag to enable a context menu item to provide the desired functionality" sounds like a pain... especially if it only sets it for one window (I can't tell from the comment).

Chromium flags are for previewing new features that get enabled for all at some point or for experimenting with some UI changes that might get enabled for all. This is the first one, as a direct response to users' request. So this will be enabled for all at some point (M83? M84?), will not stay behind a flag.

If you want to suggest a more visible option in Settings, however, that's a different thing. (As for now this only appears in the context menu.)

@bsclifton
Copy link
Member

bsclifton commented May 22, 2020

Per #9884 - @Poopooracoocoo is asking if this would be available for Android too

BTW - our Chromium 83 integration is wrapping up - should be in Nightly soon

@Sh4d0wHunt3rX
Copy link

Please add this feature in settings, that we can see the complete URL. For now I'm using this plugin:

https://chrome.google.com/webstore/detail/suspicious-site-reporter/jknemblkbdhdcpllfgbfekkdciegfboi/

I hope Brave can add it in the settings that I can remove that extension.

@diracdeltas diracdeltas added security priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 26, 2020
@diracdeltas
Copy link
Member

diracdeltas commented Jun 26, 2020

i think this would be good to add as a pref ("Show full URLs in URL bar") in brave://settings/appearance. Turning the pref on should at minimum show the URL scheme and "trivial" subdomains like www; and maybe also tweak the flags in https://github.com/bromite/bromite/blob/master/build/patches/Disable-omission-of-URL-elements-in-Omnibox.patch as needed so the full URL is shown.

cc @darkdh

EDIT: would it be sufficient to just set 'kFormatUrlOmitNothing' to true when the pref is on? it looks like then we would match the bromium behavior except they set kFormatUrlOmitMailToScheme. it seems fine to show mailto: though.

@diracdeltas diracdeltas changed the title Feature/Suggestion: Surface flag/option to display full URL in address bar Add setting in brave://settings/appearance to display full URL in address bar Jun 30, 2020
@darkdh darkdh added this to the 1.13.x - Nightly milestone Jul 17, 2020
@rebron rebron added release-notes/include and removed feature-request feature/user-interface All UI related Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Jul 20, 2020
@rebron rebron changed the title Add setting in brave://settings/appearance to display full URL in address bar [Desktop] Add setting in brave://settings/appearance to display full URL in address bar Jul 20, 2020
@Sh4d0wHunt3rX
Copy link

Any update on this?

@Poopooracoocoo
Copy link

Was this added to the Android version too?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 18, 2020

Verification passed on

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Reproduced the issue in 1.12.x
  • Verified the test plan from Add kPreventUrlElisionsInOmnibox pref in brave://settings/appearance brave-core#6116
  • Verified that github.com URL is elided when "Always Show Full URLs" option is disabled in brave://settings/appearance
    image
  • Verified that the omnibox shows full URL for github.com when "Always Show Full URLs" option is enabled in brave://settings/appearance
    image
  • Verified that context menu from Omnibox shows the option "Always Show Full URLs" in checked mode
    image

Verification passed on

Brave 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS
  • Verified the test plan from Add kPreventUrlElisionsInOmnibox pref in brave://settings/appearance brave-core#6116

  • Verified that github.com URL is elided when "Always Show Full URLs" option is disabled in brave://settings/appearance
    image

  • Verified that the omnibox shows full URL for github.com when "Always Show Full URLs" option is enabled in brave://settings/appearance
    image

  • Verified that context menu from Omnibox shows the option "Always Show Full URLs" in checked mode
    image

Verified the option is translated (checked Polish)


Verified passed with

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-20 at 1 56 23 PM

  • Verified that the omnibox shows full URL for github.com when "Always Show Full URLs" option is enabled in brave://settings/appearance

Screen Shot 2020-08-20 at 1 56 33 PM

  • Verified that context menu from Omnibox shows the option "Always Show Full URLs" in checked mode

Screen Shot 2020-08-20 at 1 56 43 PM

  • Confirmed able to turn this option off from the context menu
  • Confirmed if I turn option off from context menu and brave://settings/appearance is open, the setting is correctly reflected there
  • Confirmed if I turn this option on it is retained on browser restart

@LaurenWags LaurenWags changed the title [Desktop] Add setting in brave://settings/appearance to display full URL in address bar [Desktop] [Security] Add setting in brave://settings/appearance to display full URL in address bar Aug 20, 2020
@dentistformyeye
Copy link

dentistformyeye commented Oct 30, 2021

Could this be added to the Android version, too?
Currently, https:// and www don't show up. I've found no "Always Show Full URLs" toggle in the settings or flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment