Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make speaker button on pinned tabs un-clickable #6358

Closed
bsclifton opened this issue Oct 8, 2019 · 8 comments · Fixed by brave/brave-core#4076
Closed

Make speaker button on pinned tabs un-clickable #6358

bsclifton opened this issue Oct 8, 2019 · 8 comments · Fixed by brave/brave-core#4076

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 8, 2019

Test plan

See brave/brave-core#4076

Description

Follow up for #2025

Steps to Reproduce

  1. Play a music video on YouTube or a music stream on your favorite site
  2. Pin the tab
  3. Try to switch to and from that pinned tab without muting tab

Actual result:

Tab is accidentally muted because the click area is extremely tiny, since most of the hit box is for the mute button

Expected result:

Should be able to switch to the pinned audio tab without muting

Reproduces how often:

Brave version (brave://version info)

0.69.x and higher

@bsclifton
Copy link
Member Author

Related #5837 (comment)

@eljuno
Copy link

eljuno commented Nov 23, 2019

+1 from Community https://community.brave.com/t/remove-the-sound-icon-on-a-pinned-tab/94643?u=eljuno

@whitespacecode
Copy link

+1 Really frustrating!!

@btlechowski
Copy link

btlechowski commented Jan 4, 2020

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Also verified that the speaker button is clickable on normal tabs.

image

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.3.88 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

@LaurenWags LaurenWags changed the title Speaker button on tabs should be hidden on pinned tabs Make speaker button on pinned tabs un-clickable Jan 10, 2020
@saasseckin
Copy link

I was using that :(
Is expanding pinned tab when you hover over it not an option? @bsclifton

@bsclifton
Copy link
Member Author

@saasseckin I don't think so, unfortunately. But it will show Mute Site when you right click the pinned tab. Not as easy, but at least it's still possible

@User198263321
Copy link

Please just add an option or flag to disable it in brave://flags

@snintendog
Copy link

Please just add an option or flag to disable it in brave://flags

This should be a default for ALL Features no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment