Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive sync record CREATE, UPDATE won't be applied on receiving end #6310

Closed
darkdh opened this issue Oct 3, 2019 · 1 comment · Fixed by brave/brave-core#3602
Closed

Comments

@darkdh
Copy link
Member

darkdh commented Oct 3, 2019

This is a regression of brave-syncer(brave/brave-core#2010)
If a device receive a CREATE record and also UPDATE to this record without modifying the bookmark, the UPDATE won't be applied.

STR:

  1. Sync device A and device B
  2. Create folder F1 and bookmark B1 on toolbar of device A
  3. Wait for them to show up on device B
  4. Open chrome://inspect/#extensions on device B and inspect Brave Sync
  5. Move B1 into F1 on device A
  6. When device B receives resolved records, nothing happens on toolbar

Note: This blocks the migration of #5158

@LaurenWags
Copy link
Member

LaurenWags commented Oct 10, 2019

Verified passed with

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.70.116 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants