Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for hiding Widevine install prompt #5341

Closed
simonhong opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2980
Closed

Add option for hiding Widevine install prompt #5341

simonhong opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2980
Assignees
@simonhong
Labels
plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.69.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Jul 23, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#2980

Description

With this new option from settings or widevine install dialog, user can choose whether widevine install prompt will be visible or not.

This is simple version of #5068.
@simonhong simonhong added this to the 0.69.x - Nightly milestone Jul 23, 2019
@simonhong simonhong self-assigned this Jul 23, 2019
@simonhong simonhong mentioned this issue Jul 23, 2019
Merged
32 tasks
@simonhong simonhong mentioned this issue Jul 23, 2019
Closed
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 26, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 17, 2019 •
edited
Loading

@simonhong In the test plan brave/brave-core#2980 looks like step 7 should be notification Turn off and step 8 should be Turn on. Please clarify

@simonhong
Copy link
Member Author

@GeetaSarvadnya Done. You're right.
Initially setting was Don't ask .... but it was changed to Ask ....
I forgot to update it :) Thanks for checking 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 18, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.127 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verification passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

@kjozwiak kjozwiak mentioned this issue Sep 23, 2019
Closed
@rebron rebron changed the title Add option for hiding widevine install prompt Add option for hiding Widevine install prompt Oct 2, 2019
@kjozwiak kjozwiak mentioned this issue Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Don't show widevine install prompt when user doesn't want brave/brave-core
7 participants
@tildelowengrimm @bsclifton @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya