Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update opt-in text below Yes I'm Ready button on brave://rewards #4489

Closed
LaurenWags opened this issue May 17, 2019 · 3 comments
Closed

update opt-in text below Yes I'm Ready button on brave://rewards #4489

LaurenWags opened this issue May 17, 2019 · 3 comments
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #3124

On brave://rewards prior to ever opting into Rewards, the text below the 'Yes I'm Ready' button says "By clicking 'Yes, I'm in!..." when the button above it has different text.

Steps to Reproduce

  1. Clean profile with 0.64.95
  2. Click on BAT logo. Verify opt in text correctly references the button presented (Join Rewards)
  3. Click Learn More link.
  4. Verify opt in text below 'Yes I'm in!' buton correctly references that button.
  5. Scroll down to the bottom of the page.

Actual result:

Opt in text below the 'Yes I'm ready' button references the wrong button.
Screen Shot 2019-05-17 at 1 52 42 PM

Expected result:

"By clicking 'Yes I'm ready', you indicate that you have read and agree to the Terms of Service and Privacy Policy."

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@btlechowski
Copy link

Reproduced on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

image

@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 20, 2019
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label May 20, 2019
@jdkuki
Copy link

jdkuki commented May 21, 2019

Reproduced on

Brave 0.67.42 Chromium: 75.0.3770.38 (Developer Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 10, 2019

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
  • Verified STR from description

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description

image

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux
  • Verified the STR from the description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants