Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - PKPass Bundles cannot be installed #43338

Open
3 of 5 tasks
Brandon-T opened this issue Jan 16, 2025 · 0 comments · May be fixed by brave/brave-core#27258
Open
3 of 5 tasks

[iOS] - PKPass Bundles cannot be installed #43338

Brandon-T opened this issue Jan 16, 2025 · 0 comments · May be fixed by brave/brave-core#27258
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude

Comments

@Brandon-T
Copy link

Description

  • When trying to install .pkpasses (not the same as .pkpass), it downloads but won't install. So the user has to open the Files app and tap on it, to manually install it.

Steps to reproduce

With python flask, run the following code:

@app.route('/download-pkpass')
def download_pkpass():
    return send_file(
        'static/generic.pkpass',
        as_attachment=True,
        mimetype='application/vnd.apple.pkpass'
    )

@app.route('/download-bundle')
def download_bundle():
    return send_file(
        'static/bundle.pkpasses',
        as_attachment=True,
        mimetype='application/vnd.apple.pkpasses'
    )
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8">
    <title>Title</title>
  </head>
  <body>
    <iframe srcdoc='<a href="/download-pkpass">Download PKPass</a>'></iframe>
    <iframe srcdoc='<a href="/download-bundle">Download PKPass Bundle</a>'></iframe>
  </body>
</html>

which hosts the following files:
https://source.chromium.org/chromium/chromium/src/+/main:ios/testing/data/http_server_files/bundle.pkpasses
and
https://source.chromium.org/chromium/chromium/src/+/main:ios/testing/data/http_server_files/generic.pkpass

Actual result

  • Fails to download & install bundle

Expected result

  • Should bring up the passkit controller to install MULTIPLE passes

Reproduces how often

Easily reproduced

Brave version

  • All

Device/iOS version

  • All

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Jan 16, 2025
@Brandon-T Brandon-T self-assigned this Jan 16, 2025
@Brandon-T Brandon-T linked a pull request Jan 16, 2025 that will close this issue
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] - Add ability to download and install PKPasses (Bundled) brave/brave-core
1 participant
@Brandon-T