Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.74.x (Chromium 132). Part 2. #43327

Closed
mkarolin opened this issue Jan 15, 2025 · 3 comments · Fixed by brave/brave-core#27267
Closed

Update l10n for 1.74.x (Chromium 132). Part 2. #43327

mkarolin opened this issue Jan 15, 2025 · 3 comments · Fixed by brave/brave-core#27267

Comments

@mkarolin
Copy link
Contributor

Description
Download the latest l10n from Crowdin that wasn't completed by the release date.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

@kjozwiak
Copy link
Member

Closing as brave/brave-core#27251 was merged/uplifted into 1.74.x 👍 The above requires 1.74.49 or higher for 1.74.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 23, 2025

Verification PASSED on

Brave | 1.74.50 Chromium: 132.0.6834.111 (Official Build) (64-bit)
-- | --
Revision | f9e2d89c457e6719881a5db35f6785a4207d2b59
OS | Windows 10 Version 22H2 (Build 19045.5371)

New strings:

  1. Shared Tabs via brave://settings/content
Germany France Hindi Kannada Spanish Portuguese
Image Image Image Image Image Image

Existing strings:

Confirmed that Brave://rewards, BR panel, Brave VPN, Sidebar, NTP, brave://settings/content and brave://settings pages are translated into other locales like Germany, France, Hindi, Kannada, Spanish and Portuguese

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 23, 2025
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 23, 2025
@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 23, 2025

Verified on Samsung Galaxy S21 using version:

Brave	1.74.50 Chromium: 132.0.6834.111 (Official Build) (64-bit) 
Revision	f9e2d89c457e6719881a5db35f6785a4207d2b59
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Spot checked the app using the following locales to ensure strings are translated. Screenshots below for select languages.

    • Arabic
    • Catalan
    • Croatian
    • German
    • Hebrew
    • Korean
    • Lithunian
    • Russian
    • Slovak
Catalan (Andorra)
example example example example
Image Image Image Image
Image Image Image Image
Hebrew (Israel)
example example example example
Image Image Image
Image Image Image Image

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants