Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Rewards Panel include in a-c switch is not updated after restoring the site through rewards settings page #3610

Closed
btlechowski opened this issue Mar 6, 2019 · 1 comment
Closed

Brave Rewards Panel include in a-c switch is not updated after restoring the site through rewards settings page #3610

btlechowski opened this issue Mar 6, 2019 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@btlechowski
Copy link

btlechowski commented Mar 6, 2019 •
edited
Loading

Follow up to #3480

Steps to Reproduce

  1. Enable Rewards
  2. Open duckduckgo.com and add it to a-c table
  3. Open brave://rewards/ in another window (place the windows side by side)
  4. Show the Brave Rewards Panel on duckduckgo.com
  5. Exclude duckduckgo.com from a-c through brave://rewards/
  6. Restore duckduckgo.com to a-c through brave://rewards/
  7. Restore duckduckgo.com to a-c through Brave Rewards Panel

Actual result:

After step 6: Brave Rewards Panel is not updated.
After step 7: The excluded count is corrupted

brave_panel

Expected result:

Brave Rewards Panel is updated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.61.47 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

cc @brave/legacy_qa @NejcZdovc
@btlechowski btlechowski mentioned this issue Mar 6, 2019
Closed
@btlechowski btlechowski changed the title Brave Panel include in a-c switch is not updated after restoring the site through rewards settings page Brave Rewards Panel include in a-c switch is not updated after restoring the site through rewards settings page Mar 6, 2019
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 7, 2019 •
edited
Loading

closing this as dupe as it was fixed in 0.63 with #3497 and brave/brave-core#1803

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 7, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes labels Mar 7, 2019
@rebron rebron added closed/duplicate and removed closed/duplicate Issue has already been reported labels May 7, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 7, 2019
@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels May 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @kjozwiak @bsclifton @rebron @NejcZdovc @btlechowski