Yubikey doesn't work with Brave

[jumde]

Description

Login with U2F keys on Github or Google doesn't work

Steps to Reproduce

1. Setup U2F with Github/Google account using a yubikey
2. Login with U2F keys

Actual result:

Login doesn't work

Expected result:

Login should work

Reproduces how often:

Easily

Brave version (brave://version info)

0.62.15 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? Dev

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? No
• Is the issue reproducible on the latest version of Chrome? Not on Chrome and Chrome Canary

[rebron]

cc: @kjozwiak to reproduce

[kjozwiak]

Reproducible on 0.61.x as well. I went through both GitHub/Google using macOS 10.14.3 with the following build:

Brave	0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision	cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS	Mac OS X

Examples of the issue occurring on Google when attempting to add a key as authentication:

Chrome	Brave

Examples of the issue occurring on Google when attempting to login using an account with a key:

Examples of the issue occurring on GH when attempting to add a key as authentication:

Examples of the issue occurring on GH when attempting to login using an account with a key:

Looks like adding a key or attempting to login using a key isn't working under 0.61.x either. I went through Chrome BETA which is also on CR73 and couldn't reproduce the issue. Seems like this is Brave specific. I didn't have any issues registering a key/logging in using a key under GH/Google using the following build:

Google Chrome	73.0.3683.56 (Official Build) beta (64-bit)
Revision	303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS	Mac OS X

CCing @rebron @bbondy.

[kjozwiak]

Something to keep in mind. Chrome BETA is currently on 73.0.3683.56 and we're on 73.0.3683.39. Entirely possible that the above issue might have been fixed between those two CR versions.

@bbondy should we bump to 73.0.3683.56 and see if it's resolved?

[kjozwiak]

Bumping CR #3594. Will retest once we get new builds.

[kjozwiak]

Bumping CR again via #3608. Will retest when we get new builds which includes 73.0.3683.67.

[corymcdonald]

Is this the same issue as #1875?

[kjozwiak]

Is this the same issue as #1875?

Most likely related. Attempted to go through the case mentioned in #1875 and receiving an Operation Cancelled right off the bat. Looking into the console, I see the following:

getClientExtensionResults failed TypeError: Cannot read property 'getClientExtensionResults' of null main.js?e13936b19f427d7ade29:1 
    at main.js?e13936b19f427d7ade29:1
    at main.js?e13936b19f427d7ade29:1

Example of https://demo.yubico.com/webauthn/ under Brave:

Example of https://demo.yubico.com/webauthn/ under Chrome BETA:

I also tried using Google/Github and received the same results as before, example:

Used the following build for the above checks:

Brave	0.61.49 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Mac OS X

@rebron @bbondy @bsclifton doesn't seem like the CR bump addressed the issue. We'll need to fix this ourselves.

[kjozwiak]

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave	0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Mac OS X

• Added a yubikey under Gmail using 0.61.50 and logged in without issues using the same key
• Added a yubikey under GitHub using 0.61.50 and logged in without issues using the same key
• Went through https://demo.yubico.com/webauthn/ and ensured I can register and login using yubikey

Verification PASSED on Mint 19.1 x64 using the following build:

Brave	0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Linux

• Setup my system using https://support.yubico.com/support/solutions/articles/15000006449-using-your-u2f-yubikey-with-linux
• Added a yubikey under Gmail using 0.61.50 and logged in without issues using the same key
• Added a yubikey under GitHub using 0.61.50 and logged in without issues using the same key
• Went through https://demo.yubico.com/webauthn/ and ensured I can register and login using yubikey

Verification PASSED on Windows 10 x64 using the following build:

Brave	0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Windows

• Added a yubikey under Gmail using 0.61.50 and logged in without issues using the same key
• Added a yubikey under GitHub using 0.61.50 and logged in without issues using the same key
• Went through https://demo.yubico.com/webauthn/ and ensured I can register and login using yubikey

[aptly-io]

I cannot get Onlykey to work with U2F
On MacOS 10.14.6, Brave V1.14.84, Chromium to 85.0.4183.121
OnlyKey Firmware v0.2-beta.8c
It is as if the device does not get recognised.
It works with Firefox (it does not work on safari) on MacOS
It did work after installing Google Chrome and continued to work after removing Google Chrome.

[jumde]

@aptly-io - Does the key work with Google Chrome?

[aptly-io]

@jumde Sorry, It started working without any obvious changes (I only installed Google Chrome to test as you asked)

[jumde]

@aptly-io - That's weird, glad it's working now. If you run into this issue again, feel free to file a new issue. In the meantime, I'll try getting a OnlyKey to test.