Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP images are stretched out but shows full image when dev tools are opened #3380

Closed
srirambv opened this issue Feb 15, 2019 · 3 comments
Closed

Comments

@srirambv
Copy link
Contributor

Description

NTP images are stretched out but shows full image when dev tools are opened

Steps to Reproduce

  1. Open a new tab
  2. Be amazed by the new tab image
  3. Open dev tools, be shocked that you were looking at stretched image and not the full image

Actual result:

ezgif com-video-to-gif

Expected result:

Image should not be stretched on NTP and instead show the complete image because they are awesome

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on dev also

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

Found while verifying #1034
cc: @brave/legacy_qa to verify on other platforms
cc: @rossmoody @petemill

@btlechowski
Copy link

Reproduced on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

3380

@petemill
Copy link
Member

Can we remove references to dev tools from this issue? I’m assuming the same experience is had when the window is made thinner, right? And if so the report is really that the images aren’t being bundled high enough for the larger window sizes? If that is the real issue here, there is a trade off between installer size and image quality where the line has to be drawn somewhere. (Number of images vs file size of images vs upper limit for installer size).

@rossmoody
Copy link
Contributor

Gonna close this one after the clarification in slack design channel this morning. This is working as intended and background images are proportionally cropping (not stretching) based on viewport size.

@kjozwiak kjozwiak removed QA/Yes design A design change, especially one which needs input from the design team feature/new-tab labels Feb 27, 2019
@kjozwiak kjozwiak added this to the Dupe / Invalid / Not actionable milestone Feb 27, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants