Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons should use Brave brand style #3378

Closed
petemill opened this issue Feb 15, 2019 · 1 comment · Fixed by brave/brave-core#1422
Closed

Buttons should use Brave brand style #3378

petemill opened this issue Feb 15, 2019 · 1 comment · Fixed by brave/brave-core#1422

Comments

@petemill
Copy link
Member

Chromium webui pages all use material color palette for checkboxes. These should use brave color palette.

Test plan

Check a checkbox on the left of any history item in chrome://history and observe the buttons on the top for 'cancel' and 'delete'. They should be rounded with a black border and text.****

Old

image

New

image

@LaurenWags
Copy link
Member

LaurenWags commented Mar 25, 2019

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment