Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards publisher list is currently fetching every 48 hours. Should be set to 24 hours. #3171

Closed
jasonrsadler opened this issue Jan 31, 2019 · 4 comments · Fixed by brave/brave-core#1524

Comments

@jasonrsadler
Copy link

jasonrsadler commented Jan 31, 2019

Test Plan

brave/brave-core#1524

Description

Publisher list is fetched every 48 hours. This should be changed to 24 hours.

Steps to Reproduce

  1. Enable Rewards
  2. Wait 24 hours

Actual result:

Publisher list is not downloaded as it's set for 48 hours.

Expected result:

Publisher list should download after 24 hours.

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @mandar-brave @rebron @Miyayes

@LaurenWags
Copy link
Member

@jasonrsadler per step 4 in the test plan (brave/brave-core#1524), what should we be looking for in the terminal? I'm launching with --enable-logging=stderr --v=1 --vmodule=*rewards*=5, is that what I need to launch with in order to see some kind of messaging in the terminal?

@jasonrsadler
Copy link
Author

@LaurenWags Confused this test plan with grant checking. Updated step 4 to check timestamp on file.

@LaurenWags
Copy link
Member

thanks @jasonrsadler!

@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2019

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Used test plan from brave/brave-core#1524

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from brave/brave-core#1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment