Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields Up section in Shields Status settings page should not exist #31230

Closed
ShivanKaul opened this issue Jun 22, 2023 · 1 comment
Closed

Shields Up section in Shields Status settings page should not exist #31230

ShivanKaul opened this issue Jun 22, 2023 · 1 comment
Assignees
@spylogsster
Labels
closed/wontfix feature/shields The overall Shields feature in Brave. OS/Desktop

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jun 22, 2023 •
edited
Loading

Users can see Shields-setting-per-site via brave://settings/content/braveShields, which is accessible from the Site Settings page:

image

The Shields Down setting is very helpful because it tells you which website you've had to turn Shields down for. But given that we don't (and shouldn't) have a global Shields toggle, the Shields Up section is a bug:

image
@rebron rebron added feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Jun 23, 2023
@spylogsster
Copy link

@ShivanKaul this option used by policies #25394 cc @bsclifton @rebron

@rebron rebron removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
closed/wontfix feature/shields The overall Shields feature in Brave. OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spylogsster @ShivanKaul @rebron