In context menu on brave://sync in brave://settings, save link as... menu is disabled

[simonhong]

Test Plan

• original STR mentioned in this issue & the three cases mentioned under Prevent loading brave scheme url from javascript brave-core#1196

Original Issue Filed

Description

In context menu on brave://sync in brave://settings, save link as... menu is disabled

Steps to Reproduce

1. Open brave://settings
2. Right click on brave://sync
3. Check Save Link As... is enabled

Actual result:

Disabled

Expected result:

Enabled

Reproduces how often:

Brave version (brave://version info)

0.61.0 Chromium: 72.0.3626.28 (Developer Build)
0.59.12 Chromium: 72.0.3626.17 (Official Build) beta

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? No
• Is the issue reproducible on the latest version of Chrome? No ( it is enabled on chrome url)

Additional Information

Maybe all of brave scheme link should have this error.

[simonhong]

@kjozwiak Changed this milestone to 0.58.x hotfix2 because this was fixed by brave/brave-core#1196

[btlechowski]

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Windows 7

Used test plan from brave/brave-core#1196
Used --enable-brave-sync flag

Verification passed on

Brave	0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 7

Used test plan from brave/brave-core#1196
All TCs PASSED

Verified passed with

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

• When sync is enabled with --enable-brave-sync flag, when I go to brave://sync link in settings and right click, 'Save Link As...' is enabled.

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Linux

• Reproduced the original issues using 0.58.18 Chromium: 71.0.3578.98
• Went through Prevent loading brave scheme url from javascript brave-core#1196 and verified that all the cases are working as expected
• Used brave-browser --enable-brave-sync to enable Sync under 0.58.20 Chromium: 71.0.3578.98

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

• Reproduced the original issues using 0.58.18 Chromium: 71.0.3578.98
• Went through Prevent loading brave scheme url from javascript brave-core#1196 and verified that all the cases are working as expected
• Used /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --enable-brave-sync to enable Sync under 0.58.20 Chromium: 71.0.3578.98