Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom names for NFT's are not shown after adding NFT to portfolio #28131

Closed
srirambv opened this issue Jan 30, 2023 · 2 comments · Fixed by brave/brave-core#16913
Closed

Custom names for NFT's are not shown after adding NFT to portfolio #28131

srirambv opened this issue Jan 30, 2023 · 2 comments · Fixed by brave/brave-core#16913

Comments

@srirambv
Copy link
Contributor

Description

Custom names for NFT's are not shown after adding NFT to portfolio

Steps to Reproduce

  1. Go Add NFT screen
  2. Give it a custom name and add NFT
  3. Shows the resolved name rather than the custom name

Actual result:

Custom name is not shown

Expected result:

Should show the custom name that is added via the form

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.1105)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @muliswilliam @Douglashdaniel

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2023

The above requires 1.48.155 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2023

Verified as part of #27521 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants