Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message when there is no FIL token linked to a domain address #28041

Closed
srirambv opened this issue Jan 25, 2023 · 3 comments · Fixed by brave/brave-core#17003
Closed

Comments

@srirambv
Copy link
Contributor

Description

Update message when there is no FIL token linked to a domain address

Steps to Reproduce

  1. Select FIL in send token
  2. Type in brave-qa.crypto which is a valid domain name
  3. Shows Domain is not registered

Actual result:

image

Expected result:

Error should probably say Domain doesn't have a linked FIL address cc: @rmcfadden3 for correct wording

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.139 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @yrliou @supermassive @rmcfadden3

@rmcfadden3
Copy link

@srirambv — this one is out of my area of expertise, but on the surface your copy string looks fine to me!

@minkyeongshin
Copy link

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17003
  • Verified for EVM token, entering test.crypto shows message Domain doesn't have a linked ETH address
  • Verified for Solana token, entering test.crypto shows message Domain doesn't have a linked SOL address
  • Verified for Filecoin token, entering test.crypto shows message Domain doesn't have a linked FIL address
28041.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17003
  • Verified for EVM token, entering test.crypto shows message Domain doesn't have a linked ETH address
  • Verified for Solana token, entering test.crypto shows message Domain doesn't have a linked SOL address
  • Verified for Filecoin token, entering test.crypto shows message Domain doesn't have a linked FIL address
28041.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17003
  • Verified for EVM token, entering test.crypto shows message Domain doesn't have a linked ETH address
  • Verified for Solana token, entering test.crypto shows message Domain doesn't have a linked SOL address
  • Verified for Filecoin token, entering test.crypto shows message Domain doesn't have a linked FIL address
28041.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants