Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import extensions to target profiles during multiple import #27733

Closed
spylogsster opened this issue Jan 10, 2023 · 4 comments · Fixed by brave/brave-core#16640
Closed

Import extensions to target profiles during multiple import #27733

spylogsster opened this issue Jan 10, 2023 · 4 comments · Fixed by brave/brave-core#16640
Assignees
Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@spylogsster
Copy link

Description

Important: This issue should be solved after #27591

In issue #27591 we changed how the import works. If a user imports multiple profiles we will create new profiles (if no existing with same name) and import data from source browser to that profiles.
This issue us to add support of importing extensions to target profle instead of default.

Steps to Reproduce

  1. Create multiple profiles in Chrome with extensions.
  2. Use multiple import to import data from that profiles
  3. Check if extenions have been imported to target profiles.

Actual result:

Extensions imported only for default profile.

Expected result:

Extensions imported to target profile.

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster
Copy link
Author

cc @bsclifton @rebron

@spylogsster spylogsster changed the title Import extensions to new profiles during multiple import Import extensions to target profiles during multiple import Jan 10, 2023
@rebron rebron added onboarding Front-end related to helping a new user learn about features within the browser. feature/importer QA/Yes release-notes/include labels Jan 11, 2023
@spylogsster spylogsster self-assigned this Jan 12, 2023
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 13, 2023
@spylogsster spylogsster added this to the 1.49.x - Nightly milestone Jan 25, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 14, 2023

Verification PASSED using

Brave | 1.49.97 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Imported extensions from Chrome into MS Edge with mutliple profiles via onboarding process

Pre-requisites:

Download MS Edge browser and install extensions for Profile 2 & Profile 3
Profile 2:

  • Install ChatGPT for Google extension from Chrome Web Store
  • Install PayPal Honey and Awesome and Screenrecorder from Microsoft Edge Add-ons store

Profile 3:

  • Install MetaMask via Chrome Web Store
  • Install LastPass and Alto JPG to PDF converter
Profile 2 Profile 3
image image
  1. Install 1.49.89
  2. launch Brave
  3. click `Set Brave as default browser
  4. select Edge
  5. click import
  6. select Microsoft Edge Profile 2 & Profile 3
  7. click Import Profiles
  8. click Finish

Confirmed extensions added to Edge via Chrome Web Store are imported into Brave successfully

Profile 2: - Install ChatGPT for Google extension from Chrome Web Store
Profile 3: - Install MetaMask via Chrome Web Store

However, extensions added to Edge via Microsoft Edge Add-ons store are not imported.

step 3 step 4 step 6 step 8 new-tab Profile 2 Profile 3
image image image image image image image

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2023
@stephendonner
Copy link

stephendonner commented Feb 18, 2023

Verification PASSED using

Brave 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (x86_64)
Revision 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS macOS Version 11.7.4 (Build 20G1120)
Profile 1 Profile 2 Profile 3
Screen Shot 2023-02-17 at 10 30 52 PM Screen Shot 2023-02-17 at 10 31 05 PM Screen Shot 2023-02-17 at 10 31 23 PM

Steps:

  1. install 1.49.100
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. click Import
  6. select all profiles
  7. click Import Profiles
  8. click Finish

Confirmed extensions added to Google Chrome via Chrome Web Store are imported into Brave successfully

step 3 step 4 step 6 step 8
Screen Shot 2023-02-17 at 10 41 57 PM Screen Shot 2023-02-17 at 10 42 11 PM Screen Shot 2023-02-17 at 10 42 44 PM Screen Shot 2023-02-17 at 10 42 53 PM
new tab page profile 1 profile 2 profile 3
Screen Shot 2023-02-17 at 10 43 03 PM Screen Shot 2023-02-17 at 10 43 10 PM Screen Shot 2023-02-17 at 10 43 19 PM Screen Shot 2023-02-17 at 10 43 29 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 1, 2023

Verification PASSED using

Brave	1.49.116 Chromium: 110.0.5481.177 (Official Build) beta (64-bit) 
Revision	f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS	Linux

Chrome with multiples profiles and installed extensions

Profile 1 & 2: Extensions installed
Profile 3: No extensions installed

Person 1 Person 2 Person 3
image image image
  1. Install 1.49.116
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. click import
  6. select Chrome Person 1, Person 2, & Person 3
  7. click Import Profiles
  8. click Finish

Confirmed extensions added to Chrome via Chrome Web Store are imported into Brave successfully.

Note: Default Google Docs Offline extension is not imported as it's expected behavior
Note: Person 3 have no data/extensions but still is shown in the Brave profile manager

step 3 step 4-5 step 6 -7 step 8
image image image image
new tab page Person 1 Person 2 Person 3
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants