Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] brave today url opening issue #27602

Closed
diracdeltas opened this issue Jan 2, 2023 · 5 comments · Fixed by brave/brave-core#16519
Closed

[hackerone] brave today url opening issue #27602

diracdeltas opened this issue Jan 2, 2023 · 5 comments · Fixed by brave/brave-core#16519
Assignees
@petemill
Labels
OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.47.x - Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jan 2, 2023 •
edited by kjozwiak
Loading

credit: nishimunea
https://hackerone.com/reports/1819668

STR/Cases:

Please see https://github.com/brave/internal/issues/987#issue-1526132512 for STR/Cases.
@diracdeltas diracdeltas added security priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop labels Jan 2, 2023
@petemill petemill mentioned this issue Jan 4, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 6, 2023
This was referenced Jan 6, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2023

@brave/qa-team please post verification notes within the internal issue.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2023

The above requires 1.47.168 or higher for 1.47.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jan 10, 2023 •
edited
Loading

Verified with

Brave | 1.47.168 Chromium: 109.0.5414.87 (Official Build) (x86_64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.6.2 (Build 21G320)

See verification notes under https://github.com/brave/internal/issues/987#issuecomment-1377391238

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 10, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.47.168 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1335)

See verification notes under https://github.com/brave/internal/issues/987#issuecomment-1377538050

@btlechowski
Copy link

Verification passed on

Brave 1.47.168 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Ubuntu 18.04 LTS

Verification in https://github.com/brave/internal/issues/987#issuecomment-1377538050

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Brave News won't include items with non-http-or-https destination urls brave/brave-core
7 participants
@diracdeltas @petemill @kjozwiak @LaurenWags @btlechowski @brave-builds @MadhaviSeelam