Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News] Improve error handling for Brave News suggestions #27118

Closed
mattmcalister opened this issue Dec 2, 2022 · 2 comments · Fixed by brave/brave-core#16037
Closed

[Brave News] Improve error handling for Brave News suggestions #27118

mattmcalister opened this issue Dec 2, 2022 · 2 comments · Fixed by brave/brave-core#16037
Assignees
@fallaciousreasoning
Labels
bug feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/exclude
Milestone
1.46.x - Release #5

Comments

@mattmcalister
Copy link

Generating the Suggestions list may fail if there are data conflicts, but it needs to fail gracefully.

See crash report ID: 46ed0100-fcb4-3d09-0000-000000000000

This was likely caused by brave/source-suggestions#37 which is resolve by brave/source-suggestions#56
@fallaciousreasoning
Copy link

fallaciousreasoning commented Dec 4, 2022 •
edited
Loading

This has already been fixed in 1.47.x, we just need to uplift to 1.46.x
#26876 (see brave/brave-core#16037 for fix)

@fallaciousreasoning fallaciousreasoning mentioned this issue Dec 4, 2022
Merged
@kjozwiak kjozwiak closed this as completed Dec 7, 2022
@kjozwiak kjozwiak added this to the 1.47.x - Beta milestone Dec 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2022

This has already been fixed in 1.47.x, we just need to uplift to 1.46.x #26876 (see brave/brave-core#16037 for fix)

Labelled as QA/No as the above will be verified via #26876 as per the above.

@kjozwiak kjozwiak mentioned this issue Dec 7, 2022
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
bug feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release #5
Development

Successfully merging a pull request may close this issue.

[Brave News] Fix crash caused by bad suggestion data brave/brave-core
3 participants
@mattmcalister @kjozwiak @fallaciousreasoning