Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chromium's "acceptable ads" content setting #27010

Closed
bsclifton opened this issue Nov 28, 2022 · 3 comments · Fixed by brave/brave-core#16121
Closed

Remove Chromium's "acceptable ads" content setting #27010

bsclifton opened this issue Nov 28, 2022 · 3 comments · Fixed by brave/brave-core#16121
Assignees
Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 28, 2022

Description

Remove the Chromium Ads content setting as it's confusing; it could easily be mistaken for Brave shields Adblocking. Per @pes10k:

This setting controls Chromium’s built in “acceptable ads” policy; we block all that stuff so its 99% of the time a NOOP for us. Disabling the preference would probably make things less confusing to Brave users.

Steps to Reproduce

  1. Visit slack.com and browse a bit
  2. Open brave://settings/content/siteDetails?site=https%3A%2F%2Fslack.com
  3. Scroll down until you see Ads and Block if site shows intrusive or misleading ads

Upgrade case can also be found via brave/brave-core#16121 (comment).

Actual result:

image

Expected result:

There should not be a setting called Ads

@rebron
Copy link
Collaborator

rebron commented Dec 6, 2022

Let's keep this in 1.47.x

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2022

The above requires 1.47.121 or higher for 1.47.x verification 👍

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Case 1: New install/new profile

  1. Install 1.47.126
  2. launch Brave
  3. visit slack.com and browse a bit
  4. open brave://settings/content/siteDetails?site=https%3A%2F%2Fslack.com
  5. scroll down the page

Confirmed the Ads and Block if site shows intrusive or misleading ads setting is no longer available

Ex1 Ex2
image image

Case 2: Upgrade

  1. install 1.46.140
  2. launch Brave
  3. visit slack.com and browse a bit
  4. visit brave://settings/content/siteDetails?site=https%3A%2F%2Fslack.com
  5. scroll down the page
  6. confirmed Ads and Block if site shows intrusive or misleading ads settings is available
  7. close the browser
  8. rename the profile Brave Browser Beta
  9. launch Brave
  10. visit brave://settings/content/siteDetails?site=https%3A%2F%2Fslack.com

Confirmed the Ads and Block if site shows intrusive or misleading ads setting is no longer available

step 1 step 6 results results
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants