Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buy and Deposit buttons to the asset details screen #26213

Closed
Douglashdaniel opened this issue Oct 24, 2022 · 1 comment · Fixed by brave/brave-core#15641
Closed

Add Buy and Deposit buttons to the asset details screen #26213

Douglashdaniel opened this issue Oct 24, 2022 · 1 comment · Fixed by brave/brave-core#15641
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

We need to add Buy and Deposit buttons to the Asset Details screen.
Only show the buttons if they are supported for the asset.

Screen Shot 2022-10-24 at 2 15 37 PM

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.129 Chromium: 108.0.5359.48 (Official Build) (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Linux
  • Verified steps from brave/brave-core#15641
  • Verified Buy/Deposit buttons on asset details screen is shown
  • Verified clicking Buy from asset details screen loads Fund Wallet page
  • Verified clicking Deposit from asset details screen loads Deposit Funds page
26213.mp4

Verification passed on

Brave 1.46.129 Chromium: 108.0.5359.48 (Official Build) (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15641
  • Verified Buy/Deposit buttons on asset details screen is shown
  • Verified clicking Buy from asset details screen loads Fund Wallet page
  • Verified clicking Deposit from asset details screen loads Deposit Funds page
26213.mp4

Verification passed on

Brave 1.46.129 Chromium: 108.0.5359.48 (Official Build) (arm64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15641
  • Verified Buy/Deposit buttons on asset details screen is shown
  • Verified clicking Buy from asset details screen loads Fund Wallet page
  • Verified clicking Deposit from asset details screen loads Deposit Funds page
26213.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants