Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.ethereum.send should be writable #25078

Closed
darkdh opened this issue Aug 30, 2022 · 1 comment · Fixed by brave/brave-core#14895
Closed

window.ethereum.send should be writable #25078

darkdh opened this issue Aug 30, 2022 · 1 comment · Fixed by brave/brave-core#14895
Assignees
@darkdh
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Aug 30, 2022

https://www.mycryptoheroes.net/ and https://wallet.polygon.technology/
would do window.ethereum.send = window.ethereum.sendAsync.
We should make that function to be an exception of the property protection
@darkdh darkdh self-assigned this Aug 30, 2022
@darkdh darkdh mentioned this issue Aug 30, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 30, 2022
This was referenced Aug 30, 2022
Merged
Merged
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 31, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.85 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Linux
  • Verified test plan from brave/brave-core#14895
  • Verified no error when loading the site or when connecting wallet to the dapps
25078-Linux.mp4

Verification passed on

Brave 1.43.85 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified test plan from brave/brave-core#14895
  • Verified no error when loading the site or when connecting wallet to the dapps
25078-Windows.mp4

Verification passed on

Brave 1.43.85 Chromium: 105.0.5195.68 (Official Build) (arm64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 12.5.1 (Build 21G83)
  • Verified test plan from brave/brave-core#14895
  • Verified no error when loading the site or when connecting wallet to the dapps
25078-macOS.mov

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Make window.ethereum.send writable brave/brave-core
4 participants
@kjozwiak @darkdh @srirambv @brave-builds