Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualize Tokens List #24959

Closed
josheleonard opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14817
Closed

Virtualize Tokens List #24959

josheleonard opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14817

Comments

@josheleonard
Copy link

Description

The current Tokens list implementation renders the entire list, even if the majority of the list is not visible within the viewport

Steps to Reproduce

Scenario 1

  1. Visit brave://wallet/crypto/deposit-funds
  2. Scroll down the list of assets

Scenario 2

  1. Add many assets to the visible tokens list (including multiple NFTs)
  2. Scroll down the list of assets on the portfolio page
  3. Sort, search and filter the list

Actual result:

List takes a long time to render

Expected result:

List renders/scrolls smoothly

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from issue description and brave/brave-core#14817
  • Verified there is smooth scroll on deposit screen
  • Verified smooth scroll on portfolio with tokens and NFT's

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from issue description and brave/brave-core#14817
  • Verified there is smooth scroll on deposit screen
  • Verified smooth scroll on portfolio with tokens and NFT's

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.6 (Build 21G115)
  • Verified steps from issue description and brave/brave-core#14817
  • Verified there is smooth scroll on deposit screen
  • Verified smooth scroll on portfolio with tokens and NFT's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants