Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UD toggle wording in brave://settings/extensions #24622

Closed
supermassive opened this issue Aug 12, 2022 · 3 comments · Fixed by brave/brave-core#14910
Closed

Update UD toggle wording in brave://settings/extensions #24622

supermassive opened this issue Aug 12, 2022 · 3 comments · Fixed by brave/brave-core#14910
Assignees
@supermassive
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@supermassive
Copy link

We don't use DoH anymore
brave://settings/extensions
image
@supermassive supermassive self-assigned this Aug 12, 2022
@supermassive
Copy link
Author

@jamesmudgett @yrliou
Can you help with proper wording here, please?

@yrliou
Copy link
Member

yrliou commented Aug 12, 2022

@supermassive just Learn More about Ethereum privacy considerations. seems fine to me.

@yrliou yrliou added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 12, 2022
@supermassive supermassive mentioned this issue Aug 31, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 1, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.45.74 Chromium: 106.0.5249.55 (Official Build) beta (x86_64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 11.7 (Build 20G817)

Confirmed the wording has been updated to Learn More about Ethereum privacy considerations.

Screen Shot 2022-09-26 at 6 26 13 PM

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Remove refs to DNS over HTTPS for UD brave/brave-core
5 participants
@supermassive @stephendonner @yrliou @LaurenWags @brave-builds