Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet send address validation not checked after switching accounts #24325

Closed
StephenHeaps opened this issue Jul 28, 2022 · 1 comment · Fixed by brave/brave-core#15253
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@StephenHeaps
Copy link

Description

During a send transaction, we validate to make sure the to address does not match the from address. After switching selected accounts, this validation is not re-checked which can allow the user to create a send transaction with a matching to/from address.

Steps to Reproduce

  1. Open Send transaction panel
  2. Copy address for Account 1
  3. Enter a value to send, valid given current balance of token being sent in Account 1
  4. Use account selector to select Account 2
  5. Paste address for Account 1 in the 'to' field
  6. Use account selector to select Account 1
  7. Click 'send'
  8. Observe from address and to address are the same in the Transaction Confirmation panel

Actual result:

validation.not.checked.after.account.change.1.mov

Expected result:

Validation for send to address is checked again when the selected account is changed

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.44.5 Chromium: 104.0.5112.69 (Official Build) nightly (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 28, 2022
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jul 29, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from issue description and brave/brave-core#15253
  • Verified wallet address is verified when switching accounts
24325.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description and brave/brave-core#15253
  • Verified wallet address is verified when switching accounts
24325.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description and brave/brave-core#15253
  • Verified wallet address is verified when switching accounts
24325.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants