Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab text unreadable when using certain themes/colours - follow up to #22027 #22365

Open
kjozwiak opened this issue Apr 17, 2022 · 4 comments
Open
Assignees

Comments

@kjozwiak
Copy link
Member

Description

Similar to #22027, looks like Win 8 is still having the same issues in terms of tabs being unreadable when using certain colour and themes. Assuming we missed this on Win 8.1 as it uses a different a personalization implementation, specifically theming/colours compared to both Win 10 & Win 11.

We're also getting several reports from users within #22027 that have mentioned that Win 8 is still broken.

Steps to Reproduce

  1. install/launch 1.37.116 Chromium: 100.0.4896.127
  2. change the theme within Personalization to something darker as per the example below
  3. ensure that you change Brave's theme to Dark via brave://settings/apperance

Actual result:

Screen Shot 2022-04-17 at 7 48 11 AM

Expected result:

162881741-088afa42-9877-4e0b-ab67-fe2b3d2bd73e

Reproduces how often:

100% reproducible using the STR/Cases outlined below.

Brave version (brave://version info)

Brave | 1.37.116 Chromium: 100.0.4896.127 (Official Build) (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 8.1 (Build 9600.20337)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @simonhong @brave/qa-team

@amzero
Copy link

amzero commented May 11, 2022

Any progress in that issue?

@tomingle
Copy link

tomingle commented Jul 1, 2022

This appears to be fixed for me on Windows 8.1 & Brave 1.40.109 Chromium: 103.0.5060.66 (Official Build) (64-bit)

Possibly by brave/brave-core#13866?

@amzero
Copy link

amzero commented Jul 1, 2022

Brave

@amzero
Copy link

amzero commented Aug 5, 2022

It's not Ok, but it's much better.
brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: P3 Backlog
Development

No branches or pull requests

5 participants