Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 100 to Chromium 101. #21507

Closed
mkarolin opened this issue Mar 7, 2022 · 4 comments · Fixed by brave/brave-core#12503
Closed

Upgrade from Chromium 100 to Chromium 101. #21507

mkarolin opened this issue Mar 7, 2022 · 4 comments · Fixed by brave/brave-core#12503

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Mar 7, 2022

Upgrade from Chromium 100 to Chromium 101.

https://chromium.googlesource.com/chromium/src/+log/100.0.4896.20..101.0.4919.0/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Sync (general operation, device removing from sync chain)
  • Search engines show up correctly in the settings (fresh profile and on upgrade)
  • UI shows data correctly for:
    • Shields
    • Ad block
    • Rewards page
    • Rewards internals
    • Tipping
    • Welcome
    • IPFS
    • NTP
    • Tor internals
    • Webcompat reporter
  • Shields function correctly when changing shields settings
  • Settings UI: toggling these settings works as expected:
    • Extensions > WebTorrent
    • Extensions > Widevine
    • Privacy and security > Allow privacy-preserving product analytics (P3A)
    • Privacy and security > Automatically send daily usage ping to Brave

Android Affected areas:

  • Play video in browser
  • Top toolbar UI
  • New tab page UI
  • Partner customizations (double check that they are ignored, it applies applies only to specific vendors like Lenovo)
@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 19, 2022

Verification PASSED

Brave 1.39.67 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS Windows 11 Version 21H2 (Build 22000.593)
1.39.63 Chromium: 100.04896.127 1.39.67 Chromium: 101.0.4951.34
1 39 63C100 1 39 67C101

Verified Sync (general operation, device removing from sync chain) under #22341

Search engines show up correctly in the settings (fresh profile and on upgrade)
  • brave://settings/search
  • Verified Search engine dropdown listed as expected
  • Brave displayed Brave as a default
  • Brave search as a default works as expected.
  • Verified with Fresh install and Upgrade
IPFS
  • Upgraded to 1.39.67 Chromium: 101.0.4951.34 from 1.39.63 Chromium: 100.04896.127
  • launched Brave with --use-dev-goupdater-url
  • loaded brave://ipfs
  • clicked on Install and restart
  • Confirmed version # go-ipfs/0.12.2/brave
  • Confirmed Brave IPFS Client Updater (Windows): 1.0.75
image

Validated following:

UI shows data correctly for Rewards

  • Verified Rewards page with #22341

UI shows data correctly for Rewards internals

  • Verified Rewards internals with #22341

UI shows data correctly for Tipping

UI shows data correctly for Shields

Case 1: Shields Badge in the URL bar

  • Verified Enable Brave Shields v2 flag for Shields v2 is available by default and a flag for legacy v1 is available in brave://flags
  • Verified V1 can be enabled and used for comparison testing
  • Verified Shields badge blocked counts via icon-tip in the URL bar for a website (www.fogodechao.com) when Shields are UP as a default compared with V1
  • Verified Shields badge display grey color and no blocked count rendered via icon-tip in the location bar for a website when Shields are DOWN
ex1 ex2 ex3
V2_Shields_Up V1_Shields_Down shields_down

Case 2: Shields Panel

  • Verified correct favicons displayed for visited sites (www.washingtonpost.com, www.usatoday.com) when switched tabs including when clicked on Learn more link
  • Blocked count (15) accurate in the panel for Trackers, ads, and more blocked compared with V1 shields
  • Verified Shields toggle is ON' as a default and able to Toggle OFF
  • Verified Shields panel not displayed when clicked on the Shields badge from internal pages eg. brave://about
  • Verified Shields icon appears inactive in grey color with the internal page eg. brave://rewards
ex1 ex2 ex3
Shields_Panel_USA Shields_Panel_WP shields inactive

Case 3: Advanced Controls Panel

  • Block trackers & ads adblock count should match to Trackers, ads, and more count on the Shields panel and Shields badge for a visited site (www.washingtonpost.com)
  • Verified default settings on Advanced Controls work as expected.
  • Verified different scenarios with Trackers & ads blocked, Cookies blocked & Finger printing blocked options
Block_count_same_in_all_3_places

Shields function correctly when changing shields settings

Case 1: Verified Shields function correctly when changing shields settings on visited sites
- Verified Shields function correctly with default settings - Verified Shields work as expected when changed settings on the Shields panel
ex1 ex2
default disabled HTTPS

Case 2: Global Shields option settings propagates to sites and site specific shield options are set accordingly

  • Click on Global defaults to brave://settings/shields page
  • Verified blocked count display on the Shields badge when Show the number of blocked items on the Shields icon toggle `ON' as a default
  • Verified blocked count not rendered on the Shields badge when Show the number of blocked items on the Shields icon toggle `OFF for all sites (www.washingtonpost.com, www.usatoday.com)
  • Default settings for `Trackers & ads blocking, Upgrade connections to HTTPS, Block scripts, Block fingerprinting and Block cookies match to Shields panel
  • Verified Trackers & ads blocking is set to Aggressive, this setting is propagated to visited sites (washingtonpost.com and usatoday.com)
  • Verified Trackers & ads blocking setting can be set again to user specific setting Block trackers & ads
ex1 ex2 ex3
Globlal_settings_OFF Globlal_settings_OFF_USAtoday globa_settings

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 19, 2022

Verification PASSED on


Brave | 1.39.67 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
-- | --
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | Windows 10 Version 21H2 (Build 19044.1645)

Search engines_PASSED

Clean profile

Case 1: Regular search

  • Confirmed regular search is working as expected with default SE
  • Confirmed user can change the default SE and perform the search
  • Change the default SE from "Brave" to "Startpage" and perform a search, confirmed search is performed using Startpage SE
  • Confirmed Private tab retained "Startpage" SE
  • Confirmed Tor is still using Brave SE to perform the search

Case 2: Keyword search

  • Confirmed user can perform the keyword search using search keywords (e.g :b :br, g, etc) and results are derived from the selected SE
  • Confirmed both Space and Tab keyword searches are working as expected

Case 3: Site search

  • Confirm user can search a specific site or brave page via Site search using the preferred keyword shortcut
  • Confirmed Site search shortcuts work as expected

Case 4: Inactive shortcuts

  • Confirmed user can deactivate the Site search shortcut criteria which get added to Inactive shortcuts
  • Confirmed inactivate shortcuts can be reactivated by clicking on the Activate button

CR101 Seach engine

Upgrade profile

Case 1: Change the default SE and then upgrade the profile to CR101 build

  • Install 1.39.47 with CR100
  • Change the default SE to "Bing"
  • Upgrade the profile to 1.39.67 CR101
  • Confirmed updated SE "Bing" is retained in brave://settings/search
  • Confirmed that "Bing" is selected as default SE in brave://settings/searchEngines

Case 2: Don't change the default SE, upgrade the profile to CR101 build

  • Install 1.39.47 with CR100
  • Change the default SE to "Brave"
  • Upgrade the profile to 1.39.67 CR101
  • Confirmed updated SE "Brave" is retained in brave://settings/search
  • Confirmed that "Brave" is selected as default SE in brave://settings/searchEngines
Verify UI data_PASSED
1. UI shows data correctly for_Adblock_PASSED
2. UI shows data correctly for_Brave Rewards_PASSED
  • Confirmed AC/one-time tips and monthly tips are processed
  • Confirmed tips sent to unverified pubs are sent to the Pending contribution table
  • Confirmed AC, One-time tip,s and monthly tips are shown correctly in the monthly statement
  • Confirmed contributions are shown correctly in brave://rewrads-internals
  • Confirmed monthly tips are processed even when AC switch is OFF
  • Confirmed user can still send one-time tips when AC switch is OFF
Example Example Example Example Example Example
image image image image image image
3. UI shows data correctly for_Rewards Internals_PASSED
  • Covered the testing in case 2 above
4. UI shows data correctly for_Tipping_PASSED
  • Covered the testing in case 2 above
5. UI shows data correctly for_Welcome_PASSED
  • Confirmed that the welcome screen is showing up the 3 slides as expected
  • Confirmed content of each slide is as expected
  • Confirmed user can import bookmarks from the 2nd slide
  • Confirmed click on the Settings link in the 3rd tab navigates to P3A settings in
Example Example Example
image image image
6. UI shows data correctly for_IPFS_PASSED
  • Confirmed IPFS can be installed via the link ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • Confirmed IPNS can be installed via the link ipns://Qmc9xb2cgWKgz8rCBihag6fmvvEu7B7nbmYPxD6RcFXe1Z
  • Confirmed IPFS/IPNS status and peer, node info is shown under brave://ipfs-internals/
IPNS brave://ipfs-internals/
image image
IPFS brave://ipfs-internals/
image image
7. UI shows data correctly for_NTP_PASSED
  • Edit/update the dashboard settings from the NTP and confirmed that the updated settings are reflected on the current NTP
  • Open a new NTP and confirmed that the updated settings are reflected on the new NTP
  • Installed 1.39.47 with CR100 updated the dashboard settings in NTP and upgraded the profile to 1.39.64 with CR101 and confirmed edited/updated NTP settings are retained in an upgraded profile
1.39.47 - CR100 1.39.64 - 101
image image
8. UI shows data correctly for_TOR Internals_PASSED
  • Confirmed Tor logs are shown under the brave internal page brave://tor-internals
  • Confirmed Tor Connection Status: Disconnected when TOR is not opened or not connected to tor network 100%
  • Confirmed Tor Initialization Progress: 59% is shown on the internal page when TOR connection is in-progress
  • Confirmed Tor Connection Status: Connected when the TOR network is connected successfully
  • Confirmed Tor Connection Status: Disconnected when TOR network is disconnected or tor window is closed
  • Confirmed Tor logs are shown under the Logs tab in brave://tor-internals
Example Example Example Example Example Example
image image image image image image
9. UI shows data correctly for_Web compact reporter_PASSED
  • Confirmed web compact reporter is working as expected
  • Confirmed web compact reporter is showing up the data correctly
web compact reporter Report in stats.brave.com
image image
Settings UI_Extensions > WebTorrent_PASSED
Settings UI_Extensions > Widevine_PASSED
Settings UI_P3A_PASSED
  • Install 1.39.47 - CR100 and disable the P3A switch in brave://settings/privacy and upgrade the profile to 1.39.67- CR101 and ensured P3A is in a disabled state after the upgrade
  • Restart the browser and ensured the switch state is retained
Settings UI_Privacy and security > Automatically send daily usage ping to Brave_PASSED
  • Confirmed daily browser usage pings are sent to the server
    image

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 19, 2022

Verified using 1.39.67, Chromium 101.0.04951.34 on Android ARM devices.

Devices:
Samsung Galaxy S21 | Android 12
Samsung Galaxy Tab S7 | Android 12

Screen Shot 2022-04-19 at 11 19 12 AM

@LaurenWags
Copy link
Member

Changed to QA/No as this is superseded by #22431

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment