Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 99.0.4844.45 to Chromium 99.0.4844.51. #21370

Closed
mkarolin opened this issue Feb 28, 2022 · 7 comments · Fixed by brave/brave-core#12430
Closed

Upgrade from Chromium 99.0.4844.45 to Chromium 99.0.4844.51. #21370

mkarolin opened this issue Feb 28, 2022 · 7 comments · Fixed by brave/brave-core#12430

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/99.0.4844.45..99.0.4844.51?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2022

Will require 1.36.108 or higher.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2022

Linux is the only platform that still needs to check the affected areas via #20477 (comment). Other platforms will just need to run through a quick upgrade as the affected area's where checked/verified via #21280 (comment), #21280 (comment), #21280 (comment) & #21280 (comment).

@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.36.108 Chromium: 99.0.4844.51 (Official Build) (x86_64)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | macOS Version 12.2.1 (Build 21D62)

Screen Shot 2022-03-01 at 8 05 41 AM

@MadhaviSeelam
Copy link

Verified 'Passed' using


Brave |	1.36.108 Chromium: 99.0.4844.51 (Official Build) (64-bit) 
--|--
Revision |	d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS |	Windows 11 Version 21H2 (Build 22000.493)

136108-cr-990484451

@Uni-verse
Copy link
Contributor

Verification PASSED using version 1.36.108 Chromium 99.0.4844.51
OS: Android ARM

1 2
Screen Shot 2022-03-01 at 9 20 39 AM Screen Shot 2022-03-01 at 9 21 25 AM

@stephendonner
Copy link

Verified PASSED using

Brave 1.36.108 Chromium: 99.0.4844.51 (Official Build) (arm64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.4 (Build 20G417)

Screen Shot 2022-03-01 at 3 51 03 PM

@btlechowski
Copy link

Verification passed on

Brave 1.36.109 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

image

Sync works for newly created profiles:

Confirmed I could do the following:

  • create Sync chain
  • join Sync chain
  • left Sync chain
  • re-joined chain
brave://components

Confirmed components were present, had version numbers, and a status of either NEW, UPDATED, or UP-TO-DATE.
Confirmed clicking on Check for update flashes Checking... and finally Component not updated
Confirmed brave://components still had no errors after 8 minutes

AdBlock regional preferences settings
Confirmed that the appropriate country/language-specific filter list was selected via `brave://adblock`.

Tested: PL.

Brave News preferences

Checked the following and confirmed they worked:

  • opt-in
  • remove feed source
  • add feed source
  • add/remove (different) sources at the same time
  • add a custom RSS feed source
  • confirmed inline-content ad rendered
Handling of external URLs (including magnet)

Checked the following and ensure it worked:

Opening Guest and Tor windows from ☰ and context menus

Checked the following and ensured they worked:

  • ☰ -> File | New Private Window
  • ☰ -> File | New Private Window with Tor
  • ☰ -> Open Guest Window
  • context-click -> Open Link in Private Window
  • context-click -> Open link in Private Window with Tor
Extensions WebUI
Speedreader

Steps:

  • load nbc.com
  • clicked on the Speedreader icon in the URL bar
  • clicked on the Turn on Speedreader button

Confirmed article rendered in Speedreader mode
Confirmed Speedreader pref in brave://settings was flipped to On

Pages using brave:// scheme showing correct URL and loading

Checked the following and ensured they worked:

  • brave://bookmarks
  • brave://history/
  • brave://ipfs-internals/
  • brave://rewards/
  • brave://rewards-internals/
  • brave://settings/clearBrowserData
Settings UI / History / Bookmarks - styling changes

Spot-checked brave://settings for general appearance, usability, and correctness.

Confirmed when history is synced (typed URLs) from another device they display on brave://history.
Confirmed that history is shown for the visited websites in brave://history.
Confirmed dialogs were correct and worked.
Confirmed context-menu items on bookmarks and history items.
Confirmed bookmarks can be imported.
Confirmed bookmarks can be added/edited/deleted.
Confirmed imported bookmarks can be opened.

Check brave://flags page to make sure Brave features are listed:

Confirmed I could find Brave-specific feature flags, such as:

  • SKU
  • Easylist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment