Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Assets with 0 Balances in Panel #20955

Closed
Douglashdaniel opened this issue Feb 7, 2022 · 1 comment · Fixed by brave/brave-core#12195
Closed

Show Assets with 0 Balances in Panel #20955

Douglashdaniel opened this issue Feb 7, 2022 · 1 comment · Fixed by brave/brave-core#12195
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

We should show Assets with a 0 balance in Panel
We should also add a Add Asset button to this panel that directs to the Edit Visible Assets modal

image
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 7, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 7, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 9, 2022
Merged
24 tasks
@srirambv srirambv mentioned this issue Feb 14, 2022
Closed
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 14, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 28, 2022 •
edited
Loading

Verification completed using

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.1 (Build 21C52)
  • Verified 0 Balances on wallet panel
  • Verified 0 Balances on Portfolio, Account screens
  • Verified added new assets displays 0 Balance.
  • Add Asset button redirects to visible assets page

Screen Shot 2022-03-28 at 10 18 07 AM

Screen Shot 2022-03-28 at 10 19 11 AM

Screen Shot 2022-03-28 at 10 24 23 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Show Assets with 0 Balances in Panel brave/brave-core
2 participants
@Uni-verse @Douglashdaniel