Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkmark next to Selected Account #20549

Closed
Douglashdaniel opened this issue Jan 18, 2022 · 1 comment · Fixed by brave/brave-core#11889
Closed

Add checkmark next to Selected Account #20549

Douglashdaniel opened this issue Jan 18, 2022 · 1 comment · Fixed by brave/brave-core#11889
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@Douglashdaniel
Copy link

Description

Add a checkmark icon next the current SelectedAccount in the Select Account component.
Similar to what we do for Selected Network.

Screen Shot 2022-01-18 at 2 27 24 PM
Screen Shot 2022-01-18 at 2 26 52 PM
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jan 18, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 18, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 18, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 19, 2022
@srirambv
Copy link
Contributor

Brave 1.36.87 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11889
  • Verified checkmark is shown next to Selected account
  • Verified checkmark is shown next to both software wallet and linked hardware wallet
20549-Linux.mp4
20549-Windows.mov
20549-macOS.mov

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Added Check Mark for Selected Account brave/brave-core
2 participants
@srirambv @Douglashdaniel