Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special characters in YT channel names not appearing correctly under Rewards panel #2028

Closed
kjozwiak opened this issue Nov 7, 2018 · 1 comment · Fixed by brave/brave-core#1735

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2018

Description

YT channels that use special characters in their names are not being displayed correctly in the Rewards panel.

Steps to Reproduce

  1. launch the latest brave (0.56.8 Chromium: 70.0.3538.77 in this case)
  2. enable rewards via brave://rewards
  3. visit https://www.youtube.com/channel/UC5v8uRCMdzHXgEOZC4rtbXg
  4. click on the BAT icon in the URL to display the Rewards panel

You'll notice that it's being displayed as D\u0026E miniature and board gameson YouTube instead of D&E miniature and board games

Actual result:

screen shot 2018-11-05 at 7 19 51 pm

Expected result:

Should display D&E miniature and board games instead of D\u0026E miniature and board gameson YouTube.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under dev and beta

@btlechowski
Copy link

btlechowski commented Mar 13, 2019

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1735

image
image

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.63.8 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.12 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux mint

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment