Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to reset local transaction / nonce information #19760

Closed
bbondy opened this issue Nov 26, 2021 · 7 comments · Fixed by brave/brave-core#11721
Closed

Add a way to reset local transaction / nonce information #19760

bbondy opened this issue Nov 26, 2021 · 7 comments · Fixed by brave/brave-core#11721
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Nov 26, 2021

It's common for developers using something like Ganache to reset state on the server.
We should have a way to reset the nonce info without having to restore the whole wallet.

Via community:
https://community.brave.com/t/how-to-reset-set-transaction-nonce-in-brave-wallet-without-deleting-all-accounts/303038

But I've also had to do this before.

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 26, 2021
@DefiDebauchery
Copy link

Also incredibly helpful if you have RPC issues on alt-chains and submitted txns never complete.

@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Brave 1.36.83 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11721 description
  • Verified a new setting is available under brave://settings/wallet
  • Verified typing Yes in the new setting clears all transactions from all networks on both page and panel
19760-Linux.mp4
19760-Windows.mov
19760-macOS.mov

@jamesmudgett
Copy link

Will need to add this to Android

@kjozwiak
Copy link
Member

kjozwiak commented Mar 3, 2022

@jamesmudgett we don't re-open already resolved/tested issues as this was already released via 1.36.x on desktop. If we need this on Android, please create a new independent issue that will be used for Android.

@kjozwiak kjozwiak closed this as completed Mar 3, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 3, 2022

@jamesmudgett @srirambv assuming we can remove the OS/Android label in this case? Seems like this basically landed on desktop only so we'll need a new issue as mentioned above for Android specifically.

@Pavneet-Sing
Copy link

Pavneet-Sing commented Mar 3, 2022

thanks @kjozwiak. An issue for android has been created and linked 21457. just renamed the issue title to mimic the same.

cc: @srirambv

@kjozwiak
Copy link
Member

kjozwiak commented Mar 3, 2022

awesome, thanks @Pavneet-Sing 👍

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants