Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSea selects last connected account when multiple accounts are given #19750

Closed
bbondy opened this issue Nov 26, 2021 · 2 comments · Fixed by brave/brave-core#11459
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Nov 26, 2021

From community:
https://community.brave.com/t/brave-wallet-cannot-be-find-by-any-web3-app/303392

when you have multiple accounts connected for example to OpenSea and you switch account in Brave wallet it won’t change the account at OpenSea. In previous version of Brave Wallet it worked fine.

Upon testing what seems to happen currently is that it selects the last item in the allowed accounts array.
I think the only way for us to be compatible without the site changing is for us to only allow 1 site to have permission at a time via eth_accounts like MetaMask has.

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 26, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 26, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 26, 2021
@bbondy bbondy changed the title Report of switching account on OpenSea Report of switching account not working on OpenSea Nov 26, 2021
@bbondy
Copy link
Member Author

bbondy commented Nov 27, 2021

Upon testing what seems to happen currently is that it selects the last item in the allowed accounts array.
I think the only way for us to be compatible without the site changing is for us to only allow 1 site to have permission at a time via eth_accounts like MetaMask has.

@bbondy bbondy changed the title Report of switching account not working on OpenSea OpeanSea selects last connected account when multiple accounts are given Nov 27, 2021
@bbondy bbondy self-assigned this Dec 4, 2021
@bbondy bbondy added this to the 1.35.x - Nightly milestone Dec 9, 2021
@stephendonner stephendonner changed the title OpeanSea selects last connected account when multiple accounts are given OpenSea selects last connected account when multiple accounts are given Jan 11, 2022
@srirambv
Copy link
Contributor

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified changing account on wallet automatically changes it on Opensea as well
19750-Linux.mp4
19750-Windows.mov
19750-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants