Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet_addEthereumChain should ask users to switch chain after the network is successfully added #19291

Closed
Tracked by #19722
darkdh opened this issue Nov 8, 2021 · 1 comment · Fixed by brave/brave-core#11222
Assignees
Labels

Comments

@darkdh
Copy link
Member

darkdh commented Nov 8, 2021

In https://docs.metamask.io/guide/rpc-api.html#other-rpc-methods
The user may choose to switch to the chain once it has been added.

So our behavior difference is revealed on https://cryptomeda.tech/

STR/Cases:

Found via brave/brave-core#10939

Test plan

  1. Setup wallet
  2. Navigate to https://cryptomeda.tech/
  3. Click "Connect Wallet"
  4. Approve add network request
  5. After network is added, there will be a prompt to switch to network just added
  6. Approve switch network request
  7. The wallet should be on Polygon network
@srirambv
Copy link
Contributor

Brave 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010)
☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from issue description but used local test page
  • Verified switch network prompt is shown immediately after adding the new network chain to the list
19291.-.Linux.mp4
19291.-.Windows.mov
19291.-.macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants