Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the front end use the default currency and default cryptocurrency from settings #19234

Closed
bbondy opened this issue Nov 4, 2021 · 1 comment · Fixed by brave/brave-core#11458
Closed

Make the front end use the default currency and default cryptocurrency from settings #19234

bbondy opened this issue Nov 4, 2021 · 1 comment · Fixed by brave/brave-core#11458
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 4, 2021

Currently it only uses USD and BTC hardcoded, but we should use braveWalletService.getDefaultBaseCurrency and braveWalletService.getDefaultBaseCryptocurrency
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 4, 2021
@bbondy bbondy added front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet Integrating Ethereum+ wallet support labels Nov 8, 2021
@srirambv srirambv mentioned this issue Nov 24, 2021
Closed
@Douglashdaniel Douglashdaniel mentioned this issue Dec 6, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 8, 2021
This was referenced Dec 8, 2021
Merged
Merged
@bbondy
Copy link
Member Author

bbondy commented Dec 13, 2021

Brave 1.33.105 Chromium: 96.0.4664.93 (Official Build) (64-bit)
Revision 17531e0a70b4f8108f2418e8b5117f465077710b-refs/branch-heads/4664@{#1229}
OS Linux (skip) Windows (skip) ☑️ macOS Version 11.6
  • Opened brave://settings/wallet and tried each default currency.
  • Checked that each of the 47 currencies are reflected correctly when the ETH asset is open.
  • Checked that each of the 11 cryptocurrencies are reflected correctly when the ETH asset is open.
  • Did a transaction and made sure that the currency is updated there too
  • Checked the portfolio and made sure the currencies update there too
N/A N/A Screen Shot 2021-12-13 at 2 40 31 PM Screen Shot 2021-12-13 at 2 41 16 PM Screen Shot 2021-12-13 at 2 41 55 PM

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Implemented Default Currencies in Wallet UI brave/brave-core
3 participants
@bbondy @kjozwiak @Douglashdaniel