Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't restore sites in ac table #1883

Closed
NejcZdovc opened this issue Oct 29, 2018 · 4 comments · Fixed by brave/brave-core#835
Closed

Can't restore sites in ac table #1883

NejcZdovc opened this issue Oct 29, 2018 · 4 comments · Fixed by brave/brave-core#835

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. Enable rewards
  2. Add 3 sites to auto contribute table
  3. Remove one

Actual result:

You don't see restore option until you add at least 5 sites.

Expected result:

You should see restore before 5 sites as well and hide that option after 5 sites

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@ryanml
Copy link
Contributor

ryanml commented Oct 31, 2018

@jenn-rhim do you have any direction on where the restore action could go inside the Box panel? This should be an easy add:

screen shot 2018-10-30 at 7 05 45 pm

@NejcZdovc
Copy link
Contributor Author

I would add it to the right at the bottom. Of course this will be hidden when we do show all

image

@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 31, 2018
@jenn-rhim
Copy link

@ryanml posting the mockup reflecting what we discussed yesterday... thanks @NejcZdovc. very close. the only difference is to maintain the messaging clarity as in the overlay.

screen shot 2018-10-31 at 5 33 58 pm

@LaurenWags
Copy link
Member

LaurenWags commented Dec 11, 2018

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Test plan from brave/brave-core#835

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants