Refresh Private Window New Tab page

[rebron]

Description

Update and simplify private window new tab page. Show DDG toggle for users who have previously set DDG as their search engine. New users and existing users who have never set the toggle should not be shown the DDG setting.

New Design

All users:

Existing users with DDG on:

Current Design for Reference

Brave version (brave://version info)

n/a

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Assets

Figma: https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/?node-id=544%3A401

[stephendonner]

Verified PASSED using

Brave	1.32.63 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
Revision	e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS	macOS Version 11.6 (Build 20G165)

Steps:

1. Clean profile
2. Set brave.use_alternate_private_search_engine preference to false
3. Launched Brave
4. Opened File | New Private Window
5. Verified that Private Tab shows new design and no DuckDuckGo toggle
6. Clean profile
7. Set brave.use_alternate_private_search_engine preference to true (I set DuckDuckGo as search provider in 1.30.87, then used the profile in nightly)
8. Launched Brave
9. Opened File | New Private Window
10. Verified that Private Tab shows new design and DuckDuckGo toggle
11. Verified that toggle works as expected

Confirmed that when Search with DuckDuckGo is toggled to On, searches use DDG for search.

Confirmed that when Search with DuckDuckGo is toggled to Off, searches uses default browser.

example	example	example	example	example

[nastavoi]

Hey, can you guys clarify that with these changes, user won't be able to set default search engine for private windows independently?

[rebron]

@nastavoi The original implementation was only for DDG and it was a setting on the new tab page which wasn't necessarily a proper implementation in the sense that we'd ultimately like to offer more choices than a one choice toggle.

If an existing user had set DDG as their new tab page private window search engine, we'll display the DDG toggle. We want to honor that choice and don't want to make any changes there. New users from 1.31.x won't see that toggle though and we'll revisit how we set a search engine independently depending on window in brave://settings or we may consider a different implementation.

Hope that helps explain things.

[kjozwiak]

Clearing QA Pass-macOS as we should check this again with the next 1.30.x RC.

[GeetaSarvadnya]

Verification passed on

Brave | 1.31.86 Chromium: 95.0.4638.50 (Official Build) (64-bit)
-- | --
Revision | 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Verified the test plan from brave/brave-core#10413

Clean profile

Upgrade profile

• Install 1.30.89 DDG is OFF in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

• Install 1.30.89 DDG is ON in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

---

Verification passed on

Brave	1.31.86 Chromium: 95.0.4638.50 (Official Build) (x86_64)
Revision	3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS	macOS Version 11.6 (Build 20G165)

Verified the test plan from brave/brave-core#10413

Clean profile

Upgrade profile

• Install 1.30.89 DDG is OFF in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

• Install 1.30.89 DDG is ON in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

---

Verification PASSED on PopOS 20.04 x64 using the following build:

Brave | 1.31.86 Chromium: 95.0.4638.50 (Official Build) (64-bit)
--- | ---
Revision | 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS | Linux

Verified the STR/Cases mentioned in brave/brave-core#10413

Clean profile

Upgrade profile

• Install 1.30.89 DDG is OFF in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

• Install 1.30.89 DDG is ON in Private Tab and upgrade the profile to 1.31.86

1.30.89	1.31.86

[DivyanshuAG]

I constantly shift between Google and DDG on the private window, but now that option is no longer visible. Is there a way to get it back?

[floriegl]

@DivyanshuAG just type ":d " before your search

[simonhong]

@DivyanshuAG We are working on adding separte search engine setting for private window (brave/brave-core#13622)